Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-12: remove 'account' param from requests #82

Merged
merged 2 commits into from
Apr 13, 2022
Merged

SEP-12: remove 'account' param from requests #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2beb430
SEP-12: remove 'account' param from requests
JakeUrban Apr 6, 2022
4859944
update changelog
JakeUrban Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion @stellar/anchor-tests/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@stellar/anchor-tests",
"version": "0.3.0",
"version": "0.4.0",
"description": "stellar-anchor-tests is a library and command line interface for testing Stellar anchors.",
"main": "./lib/index.js",
"types": "./lib/index.d.ts",
Expand Down
14 changes: 5 additions & 9 deletions @stellar/anchor-tests/src/tests/sep12/getCustomer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ const newCustomerValidSchema: Test = {
);
if (!token) return result;
const customerType = getCreateCustomerType(config);
const requestParamsObj: Record<string, string> = {
account: clientKeypair.publicKey(),
};
const requestParamsObj: Record<string, string> = {};
if (customerType) requestParamsObj["type"] = customerType;
const searchParams = new URLSearchParams(requestParamsObj);
const getCustomerCall: NetworkCall = {
Expand Down Expand Up @@ -261,8 +259,8 @@ export const canFetchExistingCustomerById: Test = {
};
tests.push(canFetchExistingCustomerById);

const canFetchExistingCustomerByAccount: Test = {
assertion: "can retrieve customer using 'account'",
const canFetchExistingCustomerBySep10Token: Test = {
assertion: "can retrieve customer using SEP-10 token",
sep: 12,
group: getCustomerGroup,
dependencies: [canCreateCustomer],
Expand Down Expand Up @@ -315,9 +313,7 @@ const canFetchExistingCustomerByAccount: Test = {
}
const result: Result = { networkCalls: [] };
const customerType = getCreateCustomerType(config);
const requestParamsObj: Record<string, string> = {
account: this.context.expects.clientKeypair.publicKey(),
};
const requestParamsObj: Record<string, string> = {};
if (customerType) requestParamsObj["type"] = customerType;
const searchParams = new URLSearchParams(requestParamsObj);
const getCustomerCall: NetworkCall = {
Expand Down Expand Up @@ -353,6 +349,6 @@ const canFetchExistingCustomerByAccount: Test = {
return result;
},
};
tests.push(canFetchExistingCustomerByAccount);
tests.push(canFetchExistingCustomerBySep10Token);

export default tests;
3 changes: 0 additions & 3 deletions @stellar/anchor-tests/src/tests/sep12/putCustomer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ export const canCreateCustomer: Test = {
const putCustomerRequest = makeSep12Request({
url: this.context.expects.kycServerUrl + "/customer",
data: {
account: this.context.expects.clientKeypair.publicKey(),
...customerValues,
},
headers: {
Expand Down Expand Up @@ -295,7 +294,6 @@ export const differentMemosSameAccount: Test = {
const sep12Request = makeSep12Request({
url: this.context.expects.kycServerUrl + "/customer",
data: {
account: this.context.provides.sendingAnchorClientKeypair.publicKey(),
memo: this.context.provides.sendingCustomerMemo.value.toString(
"base64",
),
Expand Down Expand Up @@ -327,7 +325,6 @@ export const differentMemosSameAccount: Test = {
const receivingCustomerRequest = makeSep12Request({
url: this.context.expects.kycServerUrl + "/customer",
data: {
account: this.context.provides.sendingAnchorClientKeypair.publicKey(),
memo: this.context.provides.receivingCustomerMemo.value.toString(
"base64",
),
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ This changelog documents all releases and included changes to the @stellar/ancho

A breaking change will get clearly marked in this log.

## [v0.4.0](https://github.com/stellar/stellar-anchor-tests/compare/v0.3.0...v0.4.0)

### Update

- SEP-12 tests no longer include the `account` request parameter since it has been deprecated. ([#82](https://github.com/stellar/stellar-anchor-tests/pull/82))

## [v0.3.0](https://github.com/stellar/stellar-anchor-tests/compare/v0.2.0...v0.3.0)

### Update
Expand Down