Updates soroban-client version, updates use of helpers

[aristidesstaffieri]

Updates to soroban-client@0.11.2 and makes use of the new auth/tx builder related helpers.

[Shaptic]

first-pass drive-by review 🏎️

[Shaptic]

as SorobanRpc.SimulateTransactionSuccessResponse

ballsy 😝

[aristidesstaffieri]

ah yeah lol fair call out I won't cast it 😄

[aristidesstaffieri]

fixed in 736cc1d

[Shaptic]

magic numbers? deserves at least a comment

[aristidesstaffieri]

ah yeah didn't mean to leave this, still figuring out why I can't fetch the expirationLedgerSeq the way I used to and have this placeholder value for now.

[Shaptic]

ah well that's because the entry doesn't have expiration ledger anymore 😂 😭 we may put it back in later versions but tl;dr it's because the expiration is in a separate entry now from core's perspective, so you'll need to fetch it from there if you want. you have to look up the entry with the hash of the ledger key of the data

[aristidesstaffieri]

that would do it, hey thanks!

[aristidesstaffieri]

oh wait isn't that what I'm already doing here?

const key = xdr.LedgerKey.contractData(
  new xdr.LedgerKeyContractData({
    contract: new Address(contractID).toScAddress(),
    key: xdr.ScVal.scvLedgerKeyContractInstance(),
    durability: xdr.ContractDataDurability.persistent(),
  }),
);

// Fetch the current contract ledger seq
// eslint-disable-next-line no-await-in-loop
const entryRes = await server.getLedgerEntries((key));
if (entryRes.entries && entryRes.entries.length) {
  const parsed = xdr.LedgerEntryData.fromXDR(
    entryRes.entries[0].xdr,
    "base64",
  );
  // set auth entry to expire when contract data expires, but could any number of blocks in the future
  console.log(parsed);
  // expirationLedgerSeq = parsed.expiration().expirationLedgerSeq();
  expirationLedgerSeq = 81365 + 1000000;
} else {
  throw new Error(ERRORS.CANNOT_FETCH_LEDGER_ENTRY);
}

It seems like the sig changed from xdr.LedgerKey[] to xdr.LedgerKey but it still wants a LedgerKey and not a Buffer or am I missing something?

[Shaptic]

Uhh no, not quite. So yes, getLedgerEntries takes a spread rather than an array now (better ux, I hope you'd agree), but now the returned entries, as far as I understand it, probably do not have the expiration() field (see e.g. ContractDataEntry).

This is because the expiration data is now stored separately, in a separate ledger entry. What you need to do instead is request that entry, too. This means taking the hash of the ledger key that you're actually looking up: see LedgerKeyExpiration. In the above case,

const expirationKey = new xdr.LedgerKeyExpiration(SorobanClient.hash(key));

Then, you can request both: getLedgerEntries(key, expirationKey).

(and this may change with either the client or the RPC in the future, but it is what it is right now 🤷)

Does that help?

[aristidesstaffieri]

It sure does, thanks for that. Fixed in 881f8c4