Make try_ fns return smaller SDK error type #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
reviewed
Nov 22, 2023
dmkozh
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make try_ fns return smaller SDK error type instead of the large host error type.
Why
The host error type contains a massive number of possible errors. However, the host obfuscates the error when it is passed to the guest, and so the guest and sdk only ever see the Context/InvalidAction error.
It's confusing for developers if we expose the host error type, then don't actually surface most of the errors on it. A developer might think they can distingish between different error states, when in reality they cannot.
Close #1136