Restore previous auth state in client #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
commented
Nov 21, 2023
dmkozh
reviewed
Nov 21, 2023
dmkozh
approved these changes
Nov 22, 2023
|
This change at commit 49d1ba0 worked, but there were some edge cases where technically a developer could end up in a odd place by instantiating an Env, that would think it is outside a contract when it was inside. So I've opened the following change on env and updated this change to use it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Restore previous auth state in client after client finishes invoke.
Why
The client is presented in such a way that it looks like invocations with a client that has been configured with certain auth will apply the auth only during invocations with it.
It's unintuitive that the auths from the client apply forever after the invocation.
Close #1084
Dependent on: