Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check that no diffs exist after test run due to uncommitted test snapshots #1159

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Check that no diffs exist after test run due to uncommitted test snapshots #1159

merged 6 commits into from
Nov 15, 2023

Conversation

leighmcculloch
Copy link
Member

@leighmcculloch leighmcculloch commented Nov 15, 2023 •
edited
Loading

What

Check that no diffs exist after test run.

Why

It is easy to forget to generate and commit test snapshots. This will check if we missed to commit any.

Dependent on:

@leighmcculloch leighmcculloch changed the base branch from main to i1152 November 15, 2023 06:25
@leighmcculloch leighmcculloch force-pushed the require-test-snapshots-updated branch from 15119e1 to 9a9f6ab Compare November 15, 2023 06:41
@leighmcculloch leighmcculloch marked this pull request as ready for review November 15, 2023 06:41
@leighmcculloch leighmcculloch changed the base branch from i1152 to main November 15, 2023 06:41
@leighmcculloch leighmcculloch added this pull request to the merge queue Nov 15, 2023
Merged via the queue into main with commit f87ccaf Nov 15, 2023
@leighmcculloch leighmcculloch deleted the require-test-snapshots-updated branch November 15, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sisuresh sisuresh sisuresh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leighmcculloch @sisuresh