Don't block merges on rust-analyzer compat check #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-env
that referenced
this pull request
Nov 14, 2023
### What Don't block merges on rust-analyzer compat check. ### Why Lately it's taking a long time to run, longer than other jobs in the workflows. It's been more than 6 months I think since we broke this compat check. We might not need it anymore. We just don't seem to be stumbling upon limitations in rust-analyzer, we might mean the things we were stumbling on in the past have been fixed. We could remove it. Simply stopping it from blocking merges is a step towards doing that. Related: - stellar/rs-soroban-sdk#1151
sisuresh
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Don't block merges on rust-analyzer compat check.
Why
It's been more than 6 months I think since we broke this compat check. We might not need it anymore. We just don't seem to be stumbling upon limitations in rust-analyzer, we might mean the things we were stumbling on in the past have been fixed. We could remove it. Simply stopping it from blocking merges is a step towards doing that.
Related: