You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SDK function for extend_contract_instance_and_code. I think the existing extend_ttl function should be called extend_current_ttl, and this new SDK function would be extend_ttl, but I'm not sure if it's worth updating now.
I think the existing extend_ttl function should be called extend_current_ttl, and this new SDK function would be extend_ttl, but I'm not sure if it's worth updating now.
I'm not convinced about this, because otherwise we'd be attaching the term "current" to all the functions in the storage types.
I think the existing extend_ttl function should be called extend_current_ttl, and this new SDK function would be extend_ttl, but I'm not sure if it's worth updating now.
I'm not convinced about this, because otherwise we'd be attaching the term "current" to all the functions in the storage types.
My reasoning for this was due to the fact that the host functions are called extend_current_contract_instance_and_code and update_current_contract_wasm. Maybe the names would make more sense if we removed "current" and distinguished the ones that operate on other contracts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add SDK function for
extend_contract_instance_and_code. I think the existingextend_ttlfunction should be calledextend_current_ttl, and this new SDK function would beextend_ttl, but I'm not sure if it's worth updating now.