Arbitrary testutils #1134
Merged
Arbitrary testutils #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move the arbitrary module under the testutils module.
FIxes #1131
Why
All other testutils features are under the testutils module.
Known limitations
This does not leave a deprecated module of reexports in the old location, so fuzz users will experience breakage. The soroban-examples repo and the fuzzing tutorial will need to be updated.
There is other possible restructuring of the arbitrary module that could also be done, but is not, e.g. the contents of
arbitrarycould be reexported directly undertestutils.This leaves the private
arbitrary_extramodule in its current location.soroban-env-commonhas a correspondingarbitrarymodule, but it is private. Now these two crates will have their corresponding modules located in different places.I also updated the lockfile for tests/fuzz/fuzz, as Cargo seems to want it updated.