Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of signature in auth #1110

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Fix type of signature in auth #1110

merged 3 commits into from
Oct 19, 2023

Conversation

leighmcculloch
Copy link
Member

What

Change the type of the signature in custom auth from Vec to Val.

Why

The protocol and env don't actually require it to be a Vec anymore, and so the SDK is limiting the type unnecessarily.

@leighmcculloch leighmcculloch requested a review from dmkozh October 7, 2023 00:46
@leighmcculloch leighmcculloch marked this pull request as ready for review October 7, 2023 00:46
dmkozh
dmkozh approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@dmkozh dmkozh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, lost track of this.

@leighmcculloch leighmcculloch added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit fdd5027 Oct 19, 2023
@leighmcculloch leighmcculloch deleted the dissimuler-caucasoid branch October 19, 2023 20:02
@leighmcculloch
Copy link
Member Author

Oh thanks. I had forgotten about this too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmkozh dmkozh dmkozh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leighmcculloch @dmkozh