Fix typos in arbitrary docs #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brson
commented
Sep 20, 2023
| /// # } | ||
| /// # use soroban_sdk::{Address, Env, Vec, Bytes}; | ||
| /// # use soroban_sdk::arbitrary::SorobanArbitrary; | ||
| /// fuzz_target!(|input: <Bytes as SorobanArbitrary>::Prototype| { |
There was a problem hiding this comment.
This line previously used the wrong associated type name. This change makes the example a doc-test so that can't happen again.
There was a problem hiding this comment.
Ah this is very cool way to get that type checking while still not actually having to run the fuzzer in the test 👏🏻.
leighmcculloch
approved these changes
Oct 3, 2023
| /// # } | ||
| /// # use soroban_sdk::{Address, Env, Vec, Bytes}; | ||
| /// # use soroban_sdk::arbitrary::SorobanArbitrary; | ||
| /// fuzz_target!(|input: <Bytes as SorobanArbitrary>::Prototype| { |
There was a problem hiding this comment.
Ah this is very cool way to get that type checking while still not actually having to run the fuzzer in the test 👏🏻.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Just fixing a few typos.
Why
na
Known limitations
na