Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extend host functions #1240

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Rename extend host functions #1240

merged 3 commits into from
Nov 27, 2023

Conversation

SirTyson
Copy link
Contributor

What

Awhile back we renamed the extend family of functions in the SDK. This renames the host functions accordingly for consistency.

Resolves #1134.

@SirTyson SirTyson requested review from graydon, sisuresh, dmkozh and a team as code owners November 21, 2023 17:40
@dmkozh
Copy link
Contributor

dmkozh commented Nov 21, 2023

You need to bump pre-release version in soroban-env-common/meta.rs. That also means that you'll need to regenerate the test wasms, which will also mean that you need to update observations. We've actually planned to switch to pre-release 0, so this check won't be needed anymore, so maybe it would be wiser to just wait a day or two before merging this PR.

@dmkozh
Copy link
Contributor

dmkozh commented Nov 22, 2023

You need to bump pre-release version in soroban-env-common/meta.rs. That also means that you'll need to regenerate the test wasms, which will also mean that you need to update observations. We've actually planned to switch to pre-release 0, so this check won't be needed anymore, so maybe it would be wiser to just wait a day or two before merging this PR.

We've set pre-release to 0, so you shouldn't need the update anymore.

@dmkozh dmkozh added the skip-env-interface-version-bump Skip the env-interface bump version check label Nov 27, 2023
@dmkozh dmkozh enabled auto-merge November 27, 2023 19:32
@dmkozh dmkozh added this pull request to the merge queue Nov 27, 2023
auto-merge was automatically disabled November 27, 2023 20:18

Pull Request is not mergeable

Merged via the queue into stellar:main with commit bb55c40 Nov 27, 2023
github-merge-queue bot pushed a commit to stellar/rs-soroban-sdk that referenced this pull request Nov 28, 2023
### What

Small fix for env name change in PR stellar/rs-soroban-env#1240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-env-interface-version-bump Skip the env-interface bump version check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename extend to extend_ttl
2 participants