Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingest: Return progress in CheckpointChangeReader #3946

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Sep 21, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Adds Progress method to CheckpointChangeReader. Close #1666.

Why

Because number of ledger entries can change quickly (ex. 9-11M in 2 months) it's hard to estimate the progress of reading from buckets.

Known limitations

The progress value can be slightly off because ledger entries are streamed in another go routine (so the reported value can be higher than actual value if there are many entries in a buffer).

@bartekn bartekn requested a review from a team September 21, 2021 14:57
@bartekn bartekn merged commit a613f85 into stellar:master Sep 21, 2021
@bartekn bartekn deleted the bucket-reader-progress branch September 21, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better progress logs for state ingestion
2 participants