[FIX] Add asset warning details #1850
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
approved these changes
Feb 12, 2025
CassioMG
reviewed
Feb 14, 2025
| ); | ||
| await waitFor(() => screen.getByTestId("TokenWarning")); | ||
| expect(screen.getByTestId("DescriptionLabel")).toHaveTextContent( | ||
| "Add Asset", |
There was a problem hiding this comment.
Could we add the whole string here for clarity? E.g. "Add Asset Trustline"
There was a problem hiding this comment.
Yup I see, adding that. Thanks for catching it!
CassioMG
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1790
What
Fixes alignment on Add Asset warning modal
Adds handling of custom tokens