Add Publish Dry Run v2 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add Publish Dry Run v2 that publishes an explicit list of crates in an explicit order provided by inputs, rather than calculated using tooling.
Why
The existing dry run script is dependent on cargo being able to package crates without talking to crates.io. However, cargo does talk to crates.io to verify crates when building a lock file for a package, which is something it does when packaging binaries. Because of this the existing dry run script only works for libraries and not binaries.
The existing dry run script doesn't need to be told what crates to publish or what order to publish them in. It relies on cargo figuring that out, and because cargo doesn't talk to crates.io, it doesn't matter that none of the crates are published yet.
For binary crates we can't rely on cargo to package a group of crates out-of-order, and we need to provide the order they will get built in.
The v2 dry run uses this seemingly less convenient approach, that is more reliable.
For more details about the different way that cargo behaves for binaries and libraries, see rust-lang/cargo#11181.