Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ability to configure multiple BusinessHours for a single Resource #192

Closed
spalyukh-flex opened this issue May 23, 2024 · 2 comments

Comments

@spalyukh-flex
Copy link
Contributor

Problem Description

JS lib that is used under the hood allows devs to configure multiple business hours for a single resource. See https://fullcalendar.io/docs/businessHours

image

It is a useful feature when a business has a break in work during the day or if a resource is unavailable for a few hours due to some reasons.

Current implementation of the Resource class provides API to configure only one BusinessHours range.

User Story

As a software developer, I need a way to configure multiple business hours for a single resource.

Possible solution

  1. Make businessHours field in the Resource.class to be an array

image

  1. Update the implementation of Resource#toJson() to put businessHours as JsonArray instead of JsonObject

image

spalyukh-flex added a commit to spalyukh-flex/vaadin-fullcalendar that referenced this issue May 23, 2024
spalyukh-flex added a commit to spalyukh-flex/vaadin-fullcalendar that referenced this issue May 27, 2024
Done:
- Changed version in POM files to SNAPSHOT
- Added getter for BusinessHours to have backwards compatibility
- Set array to null if business hours array is empty

Link: stefanuebe#192
spalyukh-flex added a commit to spalyukh-flex/vaadin-fullcalendar that referenced this issue May 27, 2024
stefanuebe pushed a commit that referenced this issue May 29, 2024
* #192 - Add multiple BusinessHours for a Resource

Link: #192

* #192 - Fix the merge request comments

Done:
- Changed version in POM files to SNAPSHOT
- Added getter for BusinessHours to have backwards compatibility
- Set array to null if business hours array is empty

Link: #192

* #192 - Remove unnecessary constructor

Link: #192
@stefanuebe
Copy link
Owner

Directory updated.

@stefanuebe
Copy link
Owner

Thanks for your contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants