Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Add alternative deployment with a global Traefik handling HTTPS #89

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

tiangolo
Copy link
Contributor

@tiangolo tiangolo commented Jan 15, 2019

Add alternative deployment with a global Traefik proxy handling HTTPS automatically.

Each service gets HTTPS certificates and a custom domain.

Includes an alternative docker-compose.traefik.yml file and the alternative instructions to deploy it in the README.

Fix: #87

@tiangolo
Copy link
Contributor Author

Oops! I just realized I based it on #88 😰

Let me know if you prefer me to rebase it on master, in case you want to discard #88.

Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please squash the fixes into a single commit.

Thanks

Add Traefik version with HTTPS and domains

Fix grafana domain in Traefik

Fix ports in Traefik labels

Set defaults for the Traefik public tag

Fix prometheus name

Add alternative instructions for Traefik with HTTPS to the README
@tiangolo
Copy link
Contributor Author

Sure! Done ✔️

Copy link
Owner

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks great!

@stefanprodan stefanprodan merged commit efcd465 into stefanprodan:master Jan 15, 2019
@tiangolo
Copy link
Contributor Author

Awesome! Thanks! 🎉

@tiangolo tiangolo deleted the traefik branch January 15, 2019 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants