Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add deprecation message #2

Merged
merged 1 commit into from
Jan 4, 2017

Conversation

Turbo87
Copy link
Collaborator

@Turbo87 Turbo87 commented Dec 9, 2016

@alexspeller
Copy link

One thing that might be worth saying, is you can use this.transitionTo or this.replaceWith interchangeably now, it doesn't matter which you use

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 9, 2016

@alexspeller I thought about that, but it seemed more confusing for the user to give him options instead of laying out a clear path. Also in the context of a redirection the name replaceWith seems more appropriate to me.

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 9, 2016

test failure seems unrelated to this PR

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 20, 2016

@stefanpenner friendly reminder 👋

@rwjblue
Copy link

rwjblue commented Jan 4, 2017

👍 - This seems good to me. The underlying issues have been resolved (thanks to @alexspeller's work upstream)...

@stefanpenner stefanpenner merged commit 47753dc into stefanpenner:master Jan 4, 2017
@stefanpenner
Copy link
Owner

@alexspeller / @Turbo87 awesome!!

@stefanpenner
Copy link
Owner

cc @mike-north

@stefanpenner
Copy link
Owner

released as v1.0.1 so the readme on NPM is updated as well.

@Turbo87 Turbo87 deleted the patch-1 branch January 4, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants