Skip to content

Commit

Permalink
Merge pull request #87 from joetuson/film-options
Browse files Browse the repository at this point in the history
respect the film-strip option
  • Loading branch information
stefanjudis committed May 20, 2014
2 parents f129cec + e2d0550 commit 2ad24f6
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 2 deletions.
21 changes: 21 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,27 @@ grunt.initConfig( {
} );
```
### Troubleshooting
By default, the experimental `film-strip` option is true. If the grunt phantomas command fails, try setting the film strip option to false:
```js
grunt.initConfig( {
phantomas: {
yourSite : {
options : {
indexPath : './yoursite/',
options : {
'film-strip' : false
},
url : 'http://yoursite.com'
}
}
}
} );
```
### Tracking history in CI
To track history in Travis CI, use the [caching option](http://docs.travis-ci.com/user/caching/#Arbitrary-directories) to cache the `indexPath` folder.
Expand Down
2 changes: 1 addition & 1 deletion tasks/lib/phantomas.js
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ Phantomas.prototype.executePhantomas = function() {
options = _.clone( this.options.options );

// run it only for the first run
if ( i === 0 ) {
if ( i === 0 && options[ 'film-strip' ] !== false ) {
options[ 'film-strip' ] = true;
options[ 'film-strip-dir' ] = this.imagePath + this.timestamp;
}
Expand Down
2 changes: 1 addition & 1 deletion tasks/tpl/index.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@
</ul>
<% } %>
<% } %>
<h2>Last run film strip for <%= url %></h2>
<% if ( images.length ) { %>
<h2>Last run film strip for <%= url %></h2>
<ul class="p--filmstrip">
<% _.each( images, function( image ) { %>
<li><img src="images/<%= timestamp %>/<%= image %>" alt="film strip image of <%= url %>">
Expand Down

0 comments on commit 2ad24f6

Please sign in to comment.