Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tempo can be shown incorrectly #24

Closed
stefandrissen opened this issue Oct 14, 2023 · 0 comments
Closed

Tempo can be shown incorrectly #24

stefandrissen opened this issue Oct 14, 2023 · 0 comments

Comments

@stefandrissen
Copy link
Owner

stefandrissen commented Oct 14, 2023 •
edited
Loading

See 90's Club - the tempo is shown as 103 bpm when it should be 104 bpm.

The first row of the first pattern sets the tempo with F68 -> 104 bpm.

image

The tempo variable, which is relative to 100% (125 bpm) contains 0xD5. 213 / 256 * 125 bpm = 104 bpm so this is a display issue only.
@stefandrissen stefandrissen changed the title Tempo incorrect Tempo can be shown incorrectly Oct 14, 2023
stefandrissen added a commit that referenced this issue Oct 15, 2023
@stefandrissen
Round displayed percentages
2ddef55 
fixes Tempo can be shown incorrectly #24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefandrissen