Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Solid-js #90

Merged
merged 20 commits into from
Jun 16, 2021
Merged

Use Solid-js #90

merged 20 commits into from
Jun 16, 2021

Conversation

aminya
Copy link
Collaborator

@aminya aminya commented Jun 15, 2021

  • Converts ListElement to a solid-js component
  • Removes vanila-jsx
  • Uses Parcel to build the project

Fixes #27

intentions-list

@aminya aminya force-pushed the solid branch 4 times, most recently from dcd0389 to 86f1380 Compare June 15, 2021 22:41
Copy link
Collaborator Author

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: this is solved now!

This mostly works. The remaining is to make the select method working using the keyboard. The issue with the select method is that inside handleSelection the reference of the active element is needed. But I don't know how to store an array of references to the rendered elements.

For one reference, I did it using ref={} property. It already works with the mouse (onClick)

<li ref={liRef} class={isSelected(index) ? "selected" : ""}>

@aminya aminya marked this pull request as ready for review June 16, 2021 02:36
@aminya
Copy link
Collaborator Author

aminya commented Jun 16, 2021

At this point, everything works except for handleMove. The arrows don't do anything
image

@aminya
Copy link
Collaborator Author

aminya commented Jun 16, 2021

The movement handle now works 🎉

The only remaining is to fix the failing test.

@aminya aminya merged commit dfdcaa0 into master Jun 16, 2021
@aminya aminya deleted the solid branch June 16, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace vanilla-jsx with solid
1 participant