-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Solid-js #90
Use Solid-js #90
Conversation
dcd0389
to
86f1380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: this is solved now!
This mostly works. The remaining is to make the select
method working using the keyboard. The issue with the select
method is that inside handleSelection
the reference of the active element is needed. But I don't know how to store an array of references to the rendered elements.
For one reference, I did it using ref={}
property. It already works with the mouse (onClick)
intentions/lib/elements/list.tsx
Line 70 in 86f1380
<li ref={liRef} class={isSelected(index) ? "selected" : ""}> |
The movement handle now works 🎉 The only remaining is to fix the failing test. |
This simplifies the code because a reference to the element is not needed in the select handler
This fixes the movements
Fixes #27