refactor update blas/ext/base/dsumkbn2 to follow current project conventions
#1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blas/ext/base/dsumkbn2 to follow current project conventions
Planeshifter
approved these changes
Mar 23, 2024
kgryte
reviewed
Mar 23, 2024
| @@ -39,7 +39,7 @@ | |||
| * var dsumkbn2 = require( '@stdlib/blas/ext/base/dsumkbn2' ); | |||
| * | |||
| * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); | |||
| * var N = floor( x.length / 2 ); | |||
| * var N = 3;; | |||
There was a problem hiding this comment.
@Planeshifter floor should be have been removed. Would be good to ensure that ESLint can run on these examples.
kgryte
reviewed
Mar 23, 2024
| @@ -47,7 +47,7 @@ var abs = require( '@stdlib/math/base/special/abs' ); | |||
| * var floor = require( '@stdlib/math/base/special/floor' ); | |||
| * | |||
| * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); | |||
| * var N = floor( x.length / 2 ); | |||
| * var N = 4; | |||
There was a problem hiding this comment.
Same comment. floor should have been removed.
kgryte
reviewed
Mar 23, 2024
| @@ -40,17 +41,16 @@ var addon = require( './dsumkbn2.native.js' ); | |||
| * var floor = require( '@stdlib/math/base/special/floor' ); | |||
| * | |||
| * var x = new Float64Array( [ 2.0, 1.0, 2.0, -2.0, -2.0, 2.0, 3.0, 4.0 ] ); | |||
| * var N = floor( x.length / 2 ); | |||
| * var N = 4; | |||
There was a problem hiding this comment.
Same comment. floor should have been removed.
kgryte
reviewed
Mar 23, 2024
| } | ||
| ] | ||
| } | ||
| "options": {}, |
There was a problem hiding this comment.
@Planeshifter This file is missing build configurations.
kgryte
reviewed
Mar 23, 2024
Comment on lines
+38
to
+44
| STDLIB_NAPI_ARGV_INT64( env, strideX, argv, 2 ); | ||
| STDLIB_NAPI_ARGV_STRIDED_FLOAT64ARRAY( env, X, N, strideX, argv, 1 ); | ||
|
|
||
| napi_value v; | ||
| napi_create_double( env, stdlib_strided_dsumkbn2( N, X, strideX ), &v ); | ||
|
|
||
| return v; |
There was a problem hiding this comment.
This file has mixed TAB and space indentation.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1506.
Description
This pull request refactors the existing implementation to follow the current project convention for
blas/ext/base/dsumkbn2Related Issues
This pull request:
blas/ext/base/dsumkbn2to follow current project conventions #1506Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers