Update VSCode deprecated linting settings #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`python.linting.*` settings have been deprecated and split up into separate extensions; you should use the individual extensions' settings instead. https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions
|
Re: replacement for pylintEnabled: There's an extensions.json where we can recommend extensions for a workspace. https://code.visualstudio.com/docs/editor/extension-marketplace#_workspace-recommended-extensions |
So that we control the pylint & astroid version, for consistent results. This forces the extension to shell out to pylint. Without this, the extension tries to import pylint instead of running it as a subprocess, and if we use "pylint.importStrategy: fromEnvironment" to import our version of pylint, that causes all sorts of compatibility issues because the extension's dependencies (like `attrs`) come from our venv instead of the extension.
8c7f887 to
33f288e
Compare
#59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python.linting.*settings have been deprecated and split up into separate extensions; you should use the individual extensions' settings instead. See https://github.com/microsoft/vscode-python/wiki/Migration-to-Python-Tools-Extensions