Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relations currently signal that they return the following:
@return \Staudenmeir\LaravelAdjacencyList\Eloquent\Relations\belongsToManyOfDescendants<static>
While they don't create a relation query builder of static (the declaring model) but actually for the related model as passed as class string to the method. For example in
User
this code snipped:Currently the return type would say that
User
would be the query target, while it's actuallyRole
. This PR adds the genericTRelatedModel of \Illuminate\Database\Eloquent\Model
to these methods and updates@param string $related
to@param class-string<TRelatedModel> $related
so we can now define the return type as@return \Staudenmeir\LaravelAdjacencyList\Eloquent\Relations\HasManyOfDescendants<TRelatedModel>
correctly signalling that we are creating a query of the passed class string ofTRelatedModel