Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Next.js and Vite examples #290

Merged
merged 13 commits into from
Oct 10, 2022
Merged

Add Next.js and Vite examples #290

merged 13 commits into from
Oct 10, 2022

Conversation

prichodko
Copy link
Collaborator

@prichodko prichodko commented Jun 30, 2022

To see whether the component is compatible with other frameworks, I would love to add a couple of more additional frameworks to the current Parcel example.

Our goal is to provide a seamless developer experience, so this should help us with that.

@prichodko prichodko force-pushed the add-more-examples branch from f8b6dfd to ba1d223 Compare July 1, 2022 14:41
@prichodko prichodko changed the title Add more examples [examples] Add Next.js, Vite and Remix examples Jul 1, 2022
@prichodko prichodko changed the title [examples] Add Next.js, Vite and Remix examples examples: add Next.js, Vite and Remix examples Jul 1, 2022
@prichodko prichodko changed the title examples: add Next.js, Vite and Remix examples examples: Add Next.js, Vite and Remix examples Jul 1, 2022
@prichodko prichodko force-pushed the add-more-examples branch from c5314b2 to dc3349d Compare July 1, 2022 15:24
@@ -0,0 +1,21 @@
<!DOCTYPE html>
<html lang="en">
<head>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing styles.css.

@@ -1,7 +1,8 @@
{
"name": "community",
"type": "module",
"name": "with-parcel",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't support exports.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felicio felicio mentioned this pull request Sep 16, 2022
@prichodko prichodko changed the title examples: Add Next.js, Vite and Remix examples Add Next.js and Vite example Oct 10, 2022
@prichodko prichodko marked this pull request as ready for review October 10, 2022 20:14
@prichodko prichodko requested a review from felicio October 10, 2022 20:14
@prichodko
Copy link
Collaborator Author

prichodko commented Oct 10, 2022

I removed with-remix example for now. libp2p relies heavily on Node builtin modules and expects consumers to provide polyfills for them – which I believe is not the right approach.

Remix currently does not support polyfilling (remix-run/remix#114) and requires manual patching of their compiler.

@prichodko prichodko changed the title Add Next.js and Vite example Add Next.js and Vite examples Oct 10, 2022
@felicio felicio merged commit 0f9a175 into main Oct 10, 2022
@felicio felicio deleted the add-more-examples branch October 10, 2022 20:26
felicio pushed a commit to felicio/status-web that referenced this pull request May 15, 2023
* rename community to with-parcel

* add with-next example

* update example names and unify configs

* add vite example

* use new JSX transform in examples

* disable necessary eslint rules for examples

* add next output to prettierignore

* add remix example

* update engines in package.json

* remove readme from with-next example

* update vite example

* update with-next example

* remove with-remix example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants