Multiline chat input #575
Closed
Multiline chat input #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't look like correct behavior
|
rasom
reviewed
Dec 22, 2016
| @@ -54,9 +51,16 @@ | |||
| :accessibility-label :input | |||
| :on-focus #(do (dispatch [:set :focused true]) | |||
| (dispatch [:set-chat-ui-props :show-emoji? false])) | |||
| :on-blur #(do (dispatch [:set :focused false]) | |||
| :on-blur #(do (reset! message-text "") | |||
There was a problem hiding this comment.
WARNING: Use of undeclared Var status-im.chat.views.message-input/message-text at line 54 src/status_im/chat/views/message_input.cljs
|
Sounds crazy, but it's almost 2017 and React Native still doesn't completely support the desired behaviour: facebook/react-native#1882 |
d499f99 to
a58ed1a
Compare
|
@alwx, maybe I just don't understand, but why should we send the message when user presses Return? I imagine that users will expect a new line in the result of this action. Or I miss something? |
|
hmm on return it shouldn't send the message |
|
Ok, sorry. I will close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've copied some code from drawer to chat to allow users to send messages by tapping Enter on the keyboard (previously it didn't work well on iOS)