-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection avatar component #17462
Collection avatar component #17462
Conversation
Jenkins BuildsClick to see older builds (15)
|
(:require [quo2.components.avatars.collection-avatar.view :as collection-avatar] | ||
[test-helpers.component :as h])) | ||
|
||
(defonce bored-ape (js/require "../resources/images/mock2/bored-ape.png")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to get this from the resources file instead? 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-Son89, do you mean not from the mock
folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no that's fine. I mean that we have a quo2.resources file so can we use that instead? and do the resources/get-mock-image
approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-Son89 ah, okay)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-Son89, just remembered why it is this way.resources/get-mock-image
located in status-im2
, whereas component is in quo2. And our linter fails with warnings when we reference status-im2 from quo2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh we have another file like that within quo2 for this reason though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@J-Son89, thanks, missed it!)
(:require [quo2.components.avatars.collection-avatar.style :as style] | ||
[quo2.theme :as quo.theme] | ||
[react-native.fast-image :as fast-image] | ||
)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: formatting is strange here
src/quo2/core.cljs
Outdated
@@ -149,6 +150,7 @@ | |||
(def icon-avatar quo2.components.avatars.icon-avatar/icon-avatar) | |||
(def user-avatar quo2.components.avatars.user-avatar.view/user-avatar) | |||
(def wallet-user-avatar quo2.components.avatars.wallet-user-avatar/wallet-user-avatar) | |||
(def collection-avatar quo2.components.avatars.collection-avatar.view/view) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we keep this list alpha sorted too 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small comments, book looks good otherwise 🚀
@Francesca-G, could you please take a look at this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ✨
6f8ede2
to
986acaa
Compare
49% of end-end tests have passed
Failed tests (22)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Passed tests (21)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
|
986acaa
to
ffadfcb
Compare
fixes #17463
Summary
Collection avatar added to the list of quo components
Design: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=28941-78785&mode=dev
Design notes:
Quo component can be found in "avatars" section of the app.
![Screenshot 2023-10-02 at 11 32 46](https://private-user-images.githubusercontent.com/5786310/271947496-f18efc1c-ff2a-4dd5-b54b-d662508be7de.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMTQ2MjQsIm5iZiI6MTczOTIxNDMyNCwicGF0aCI6Ii81Nzg2MzEwLzI3MTk0NzQ5Ni1mMThlZmMxYy1mZjJhLTRkZDUtYjU0Yi1kNjYyNTA4YmU3ZGUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMTkwNTI0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGM1NzFmNjljMDU2NmVjMDQyMDgzYjg3OWViMjFmMDhlM2Y3NzUwYTU4ZDA1ZDIxNTk1M2NjZGNmZjk5MmZlMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.yHtVjA8jCw4Cwx5tgpaAeqfiMaQPI9oRN6hIp-DOep0)
status: ready