Ordered trie for trie root computations #6610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives a 100x speed boost for this operation which happens during optimistic sync when computing the block hash.
d1e701a to
13d2d8e
Compare
etan-status
reviewed
Oct 8, 2024
etan-status
reviewed
Oct 8, 2024
beacon_chain/spec/helpers.nim
Outdated
| requests.withdrawals.len + | ||
| requests.consolidations.len | ||
|
|
||
| if n == 0: |
There was a problem hiding this comment.
Can the EMPTY_ROOT_HASH optimization be integrated into the OrderedTrieRootBuilder? Then we don't need EMPTY_ROOT_HASH in helpers anymore.
There was a problem hiding this comment.
Can the EMPTY_ROOT_HASH optimization be integrated into the OrderedTrieRootBuilder? Then we don't need EMPTY_ROOT_HASH in helpers anymore.
it's already there actually, 429bb2e
Co-authored-by: Etan Kissling <etan@nimbus.team>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a 100x speed boost for this operation which happens during optimistic sync when computing the block hash.