Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VC: Enable block monitoring by default #6331

Merged
merged 1 commit into from
Jun 7, 2024
Merged

VC: Enable block monitoring by default #6331

merged 1 commit into from
Jun 7, 2024

Conversation

cheatfate
Copy link
Contributor

This feature should address issue #4111

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

Unit Test Results

         9 files  ±0    1 325 suites  ±0   25m 24s ⏱️ - 6m 46s
  4 986 tests ±0    4 638 ✔️ ±0  348 💤 ±0  0 ❌ ±0 
20 814 runs  ±0  20 410 ✔️ ±0  404 💤 ±0  0 ❌ ±0 

Results for commit 0fa5480. ± Comparison against base commit e7e69da.

@tersec tersec enabled auto-merge (squash) June 7, 2024 12:07
tersec
tersec reviewed Jun 7, 2024
View reviewed changes
beacon_chain/conf.nim
@@ -1047,7 +1047,7 @@ type

monitoringType* {.
desc: "Enable block monitoring which are seen by beacon node (BETA)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still beta?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we never tested it without this feature enabled, probably yes.

@tersec tersec disabled auto-merge June 7, 2024 12:10
@tersec tersec merged commit 0512d02 into unstable Jun 7, 2024
15 checks passed
@tersec tersec deleted the vc-enable-block-monitor branch June 7, 2024 15:04
@tersec
Copy link
Contributor

tersec commented Jun 8, 2024

It's functioning on the fleet (here, neth-10.ih-eu-mda1.nimbus.holesky):

$ datamash perc:5 1 perc:10 1 perc:20 1 perc:25 1 perc:30 1 perc:40 1 < dela
ys_prev.txt 
99	136	193	221	246	284
$ datamash perc:5 1 perc:10 1 perc:20 1 perc:25 1 perc:30 1 perc:40 1 < dela
ys_cur.txt 
-480	-348	-135	-30	73	214

times normalized to milliseconds

@tersec tersec mentioned this pull request Jun 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnetheduck arnetheduck arnetheduck approved these changes

@tersec tersec tersec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheatfate @tersec @arnetheduck