Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update process_attester_slashing/process_proposer_slashing/process_voluntary_exit/process_transfer API #415

Closed
mratsim opened this issue Sep 9, 2019 · 1 comment
Closed

Update process_attester_slashing/process_proposer_slashing/process_voluntary_exit/process_transfer API #415

mratsim opened this issue Sep 9, 2019 · 1 comment

Comments

@mratsim
Copy link
Contributor

mratsim commented Sep 9, 2019

Still at 0.6.3 and 0.7.1:

https://github.com/status-im/nim-beacon-chain/blob/3f446e63838e9e78ad67ebd0cd88f2fa0f5e68b5/beacon_chain/spec/state_transition_block.nim#L140-L143

https://github.com/status-im/nim-beacon-chain/blob/3f446e63838e9e78ad67ebd0cd88f2fa0f5e68b5/beacon_chain/spec/state_transition_block.nim#L198-L204

We're not using the AttesterSlashing/Proposer objects https://github.com/ethereum/eth2.0-specs/blob/v0.8.3/specs/core/0_beacon-chain.md#attester-slashings
mratsim added a commit that referenced this issue Sep 9, 2019
@mratsim
attester slashing tests - pending #415
9630b65
@mratsim
Copy link
Contributor Author

mratsim commented Sep 9, 2019 •
edited
Loading

Same for VoluntaryExit and transfer objects:
https://github.com/status-im/nim-beacon-chain/blob/d4c480ff5fe9258fa6916d9981e8ef032d118a0c/beacon_chain/spec/state_transition_block.nim#L330-L332
https://github.com/status-im/nim-beacon-chain/blob/d4c480ff5fe9258fa6916d9981e8ef032d118a0c/beacon_chain/spec/state_transition_block.nim#L377-L379

@mratsim mratsim changed the title Update process_attester_slashing/process_proposer_slashing API Update process_attester_slashing/process_proposer_slashing/process_voluntary_exit API Sep 9, 2019
@mratsim mratsim changed the title Update process_attester_slashing/process_proposer_slashing/process_voluntary_exit API Update process_attester_slashing/process_proposer_slashing/process_voluntary_exit/process_transfer API Sep 9, 2019
@mratsim mratsim mentioned this issue Sep 9, 2019
Merged
@tersec tersec mentioned this issue Sep 10, 2019
Merged
mratsim added a commit that referenced this issue Sep 10, 2019
@mratsim
attester slashing tests - pending #415
389c45b
mratsim added a commit that referenced this issue Sep 10, 2019
@mratsim
Attester slashing - split process_attester_slashing/processAttesterSl…
6be2e24 
…ashings + tests (#424)

* attester slashing tests - pending #415

* split process_attester_slashing/processAttesterSlashings

* Add logs to attester_slashing

* deactivate bls tests for now (#429) and cherry-pick from 60f2437
@mratsim mratsim mentioned this issue Sep 11, 2019
Closed
@mratsim mratsim closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mratsim