Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test environment for studying crash of hexary trie #938

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

mjfh
Copy link
Contributor

@mjfh mjfh commented Jan 21, 2022

why:
the persistent test case will crash unless in genesis.toBlock():

  • pruneTrie is set false, or
  • the directive "tdb.put(emptyRlpHash.data,emptyRlp)" is added right
    before the "for k, v in account.storage:" loop

@mjfh mjfh requested a review from jlokier January 21, 2022 16:53
@mjfh mjfh force-pushed the jordan/kintsugi-hexary-trie-crasher branch 5 times, most recently from 3306e36 to 8f58ddb Compare January 21, 2022 21:25
why:
  the persistent test case will crash unless in genesis.toBlock():
  + pruneTrie is set false, or
  + the directive "tdb.put(emptyRlpHash.data,emptyRlp)" is added right
    before the "for k, v in account.storage:" loop
@mjfh mjfh force-pushed the jordan/kintsugi-hexary-trie-crasher branch 6 times, most recently from 439f37b to 72dcf16 Compare January 25, 2022 09:31
@stefantalpalaru
Copy link
Contributor

See if you're running into this problem: status-im/nimbus-eth2#3121

@mjfh mjfh force-pushed the jordan/kintsugi-hexary-trie-crasher branch 2 times, most recently from 3843ef0 to 9f6b51f Compare January 25, 2022 10:39
@mjfh
Copy link
Contributor Author

mjfh commented Jan 25, 2022

See if you're running into this problem: status-im/nimbus-eth2#3121

Thanks, but this is not the problem. For windows, there were stale file locks which prevented the deferred removal of the persistent database.

There are segfault problems on Linux/i386 which I cannot reproduce on my machine .. but I am on it :)

@mjfh
Copy link
Contributor Author

mjfh commented Jan 25, 2022

See if you're running into this problem: status-im/nimbus-eth2#3121

Thanks, but this is not the problem. For windows, there were stale file locks which prevented the deferred removal of the persistent database.

There are segfault problems on Linux/i386 which I cannot reproduce on my machine .. but I am on it :)

But I realise that this might be a simillar issue on the Linux/i386. And yes, it haunts me too.

@mjfh mjfh force-pushed the jordan/kintsugi-hexary-trie-crasher branch 3 times, most recently from 96f9a49 to 7ae2e81 Compare January 25, 2022 17:16
@mjfh mjfh force-pushed the jordan/kintsugi-hexary-trie-crasher branch from 7ae2e81 to 93a52e5 Compare January 25, 2022 18:31
@mjfh mjfh merged commit bced43c into master Jan 26, 2022
@mjfh mjfh deleted the jordan/kintsugi-hexary-trie-crasher branch January 26, 2022 11:56
@mjfh mjfh restored the jordan/kintsugi-hexary-trie-crasher branch January 26, 2022 12:02
@mjfh mjfh deleted the jordan/kintsugi-hexary-trie-crasher branch January 26, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants