Improvements to discv5 sessions #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kdeme
commented
Feb 7, 2025
- Adjust Sessions API to make use of results.Opt instead of var params
- Add loadReadKey for when only the readKey is required
- Add 32-bit counter to a Session and add nextNonce call that creates the nonce to use for next encryption (using the 32-bit counter)
- Use nextNonce in discv5 encryption
- Tests for Sessions / nextNonce
- Adjust Sessions API to make use of results.Opt instead of var params - Add loadReadKey for when only the readKey is required - Add 32-bit counter to a Session and add nextNonce call that creates the nonce to use for next encryption (using the 32-bit counter) - Use nextNonce in discv5 encryption - Tests for Sessions / nextNonce
69a2db3 to
e98c05f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.