Added additional tests to cover HexaryTrie MPT proofs. #650
Conversation
tests/trie/test_hexary_proof.nim
Outdated
|
|
||
| check: | ||
| trie.rootHash == keccakHash(emptyRlp) | ||
| proof.len() == 1 # Maybe this should return an empty list? |
There was a problem hiding this comment.
I think it makes sense that it is len() == 1 considering it drops in the empty rlp value?
The fact that the result is InvalidProof is however inconsistent for when you would add a "not-exist` into a not empty trie. The emptry trie thing is quite the edge case though.
There was a problem hiding this comment.
Yeah it is an edge case so probably not worth spending too much time on. I raised it because I noticed that this library behaves differently than the Rust implementation which returns an empty proof when the trie is empty.
There was a problem hiding this comment.
I'd suggest to add a Note in comment that explains this and perhaps also link to this rust library.
tests/trie/test_hexary_proof.nim
Outdated
| let db = newMemoryDB() | ||
| var trie = initHexaryTrie(db) | ||
|
|
||
| let |
There was a problem hiding this comment.
I noticed quite some trailing whitespace in this and previous PR. You might want to setup up some marking and/or trimming of that.
There was a problem hiding this comment.
Do you mean at the bottom of the file? Or spaces after the let?
There was a problem hiding this comment.
spaces after the let and some other locations.
|
@kdeme I've updated the code as you suggested. Ready for the final review. Thanks |
No description provided.