untrusted peer downloader validation #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JekaMas
approved these changes
Jun 15, 2018
les/fetcher.go
Outdated
| for n != nil { | ||
| if td = f.chain.GetTd(n.hash, n.number); td != nil { | ||
| if n.hash == h.Hash() { |
themue
suggested changes
Jun 15, 2018
les/fetcher.go
Outdated
| @@ -523,6 +524,7 @@ func (f *lightFetcher) newFetcherDistReqForSync(bestHash common.Hash) *distReq { | |||
| go func() { | |||
| p := dp.(*peer) | |||
| p.Log().Debug("Synchronisation started") | |||
| f.lastTrustedHeader = f.chain.CurrentHeader() | |||
There was a problem hiding this comment.
Is it safe setting this shared field asynchronously in goroutines?
les/fetcher.go
Outdated
| for last != nil { | ||
| if f.isTrustedHash(last.hash) { | ||
| current := f.chain.CurrentHeader() | ||
| for current != nil || current != f.lastTrustedHeader { |
There was a problem hiding this comment.
Here is where I meant the comparison of the lastTrustedHeader set async in a goroutine.
|
@themue fixed |
|
@b00ris Seen my comment regarding setting it inside the goroutine? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #63