Add Transport Option to allow egress proxies #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `Transport` to the `Options` struct when constructing a new instance of the Go SDK. If set it allows the end user to pass in their own `http.RoundTripper` instead of using `http.DefaultTransport`. The reasoning for this change it to allow users to provide a transport which is capabile of acting as middleware for the outbound requests made by the SDK (such as allowing routing via an authenticated egress proxy).
|
Released in v1.28.0 - Transport override option & bug fixes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
Transportto theOptionsstruct when constructing a new instance of the Go SDK. If set it allows the end user to pass in their ownhttp.RoundTripperinstead of usinghttp.DefaultTransport.The reasoning for this change it to allow users to provide a transport which is capabile of acting as middleware for the outbound requests made by the SDK (such as allowing routing via an authenticated egress proxy).