Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env prompt: Escape sequences #709

Closed
max06 opened this issue Nov 29, 2024 · 3 comments · Fixed by #717
Closed

Env prompt: Escape sequences #709

max06 opened this issue Nov 29, 2024 · 3 comments · Fixed by #717
Assignees
@sourishkrout
Labels
bug Something isn't working

Comments

@max06
Copy link

max06 commented Nov 29, 2024

Hello there!

Just an optical inconvenience...

Given following snippet:

export TYPE=[Guest type \(hyperv,proxmox,openstack\)]
export TARGET=[IP of waiting server]

Result:
image

The backslash-escape in front of the parentheses is required in bash. Runme should probably parse, sanitize and display these properly.
@sourishkrout
Copy link
Member

Thanks for reporting, @max06! We will get that fixed in the following weeks.

@sourishkrout sourishkrout added the bug Something isn't working label Dec 2, 2024
@sourishkrout sourishkrout self-assigned this Dec 2, 2024
This was referenced Dec 17, 2024
Closed
Merged
@sourishkrout sourishkrout linked a pull request Dec 17, 2024 that will close this issue
Unescape shell literal if it's not a placeholder #717
Merged
sourishkrout added a commit that referenced this issue Dec 17, 2024
@sourishkrout
Unescape shell literal if it's not a placeholder (#717)
e462959 
Prompt messages are unquoted which requires them to be valid shell. Any
values not quoted become prompt messages and are exclusively for human
consumption. This is why we're removing backslashes from any form of
parentheses.

Fixes #709.
@sourishkrout
Copy link
Member

The cosmetic fix will go out with the next stable release, @max06.

@max06
Copy link
Author

max06 commented Dec 18, 2024

Lovely, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sourishkrout sourishkrout

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@sourishkrout @max06