Updates as per Laravel 7 upgrade guide #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jasonvarga
requested changes
Mar 20, 2020
|
Changing the exception handler class will work for Laravel 7 but break everything else. I think we need to work out how to get rid of it. Related to #1295 |
|
New PR in |
|
Seems like the minify PR Is merged! |
@jasonvarga do think this is something one of us could tackle or will this require a deeper knowledge of how Statamic is all wired up? If the former, do you have a suggested starting point? |
jasonvarga
reviewed
Apr 2, 2020
Merged
|
Official PR #1679 |
|
Leave it open and you can get a cool purple merged badge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is something you're open to, but this seems to get Statamic up to Laravel 7, although you need to wait for mrclay/minify#666 to actually get there.
However all of these changes should work for L5.8+ regardless to be ready!