Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add default config for select starter kit modules #11045

Merged
merged 9 commits into from
Nov 26, 2024
Merged

[5.x] Add default config for select starter kit modules #11045

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fbd18e2
Spec out `default` config for select module types, when `prompt: false`.
jesseleite Nov 2, 2024
30332e2
Pass tests.
jesseleite Nov 2, 2024
3a04a86
Tweak tests.
jesseleite Nov 2, 2024
e8ffb6b
Fix implementation to match updated PR description.
jesseleite Nov 2, 2024
92139cf
Flesh out test coverage for new `skip_option: false` functionality.
jesseleite Nov 2, 2024
7871611
Auto-select `default` value as well.
jesseleite Nov 24, 2024
9b96847
Fix `$default` handling on confirmation module.
jesseleite Nov 26, 2024
7b5df64
Add test coverage for `default: true` on confirmation non-interactively.
jesseleite Nov 26, 2024
98867da
Pass test.
jesseleite Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Spec out default config for select module types, when prompt: false.
  • Loading branch information
@jesseleite
jesseleite committed Nov 2, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit fbd18e2d7720567a6be49cda2e8280e62d400cb7
60 changes: 58 additions & 2 deletions tests/StarterKits/InstallTest.php
View file
Original file line number Diff line number Diff line change
@@ -780,7 +780,7 @@ public function it_installs_modules_with_prompt_false_config_by_default_when_run
],
'modules' => [
'seo' => [
'prompt' => false, // Setting prompt to false skips confirmation, so this module should still get installed non-interactively
'prompt' => false, // Setting prompt to false skips confirmation, so this module should still get installed
'export_paths' => [
'resources/css/seo.css',
],
@@ -797,11 +797,39 @@ public function it_installs_modules_with_prompt_false_config_by_default_when_run
],
],
'jamaica' => [
'prompt' => false, // Setting prompt to false skips confirmation, so this module should still get installed non-interactively
'prompt' => false, // Setting prompt to false skips confirmation, so this module should still get installed
'export_as' => [
'resources/css/theme.css' => 'resources/css/jamaica.css',
],
],
'js' => [
'prompt' => false, // Setting prompt to false skips confirmation, so this module should still get installed
'default' => 'vue', // And a `default` is required so that we know which one to install
'options' => [
'react' => [
'label' => 'React JS',
'export_paths' => [
'resources/js/react.js',
],
],
'vue' => [
'label' => 'Vue JS',
'export_paths' => [
'resources/js/vue.js',
],
],
],
],
'js_invalid' => [
'prompt' => false, // Setting prompt to false without a `default`, is not valid config
'options' => [
'svelte' => [
'export_paths' => [
'resources/js/svelte.js',
],
],
],
],
],
]);

@@ -811,6 +839,9 @@ public function it_installs_modules_with_prompt_false_config_by_default_when_run
$this->assertFileDoesNotExist(base_path('resources/css/theme.css'));
$this->assertComposerJsonDoesntHave('statamic/seo-pro');
$this->assertComposerJsonDoesntHave('bobsled/speed-calculator');
$this->assertFileDoesNotExist(base_path('resources/js/react.js'));
$this->assertFileDoesNotExist(base_path('resources/js/vue.js'));
$this->assertFileDoesNotExist(base_path('resources/js/svelte.js'));

$this->installCoolRunnings();

@@ -820,6 +851,9 @@ public function it_installs_modules_with_prompt_false_config_by_default_when_run
$this->assertFileExists(base_path('resources/css/theme.css'));
$this->assertComposerJsonHasPackageVersion('require', 'statamic/seo-pro', '^0.2.0');
$this->assertComposerJsonDoesntHave('bobsled/speed-calculator');
$this->assertFileDoesNotExist(base_path('resources/js/react.js'));
$this->assertFileExists(base_path('resources/js/vue.js'));
$this->assertFileDoesNotExist(base_path('resources/js/svelte.js'));
}

#[Test]
@@ -1179,6 +1213,24 @@ public function it_installs_nested_modules_with_prompt_false_config_by_default_w
'resources/dictionaries/canadian_players.yaml',
],
],
'js' => [
'prompt' => false, // Setting prompt to false skips confirmation, so this module should still get installed
'default' => 'vue', // And a `default` is required so that we know which one to install
'options' => [
'react' => [
'label' => 'React JS',
'export_paths' => [
'resources/js/react.js',
],
],
'vue' => [
'label' => 'Vue JS',
'export_paths' => [
'resources/js/vue.js',
],
],
],
],
],
],
],
@@ -1192,6 +1244,8 @@ public function it_installs_nested_modules_with_prompt_false_config_by_default_w
$this->assertFileDoesNotExist(base_path('resources/dictionaries/players.yaml'));
$this->assertFileDoesNotExist(base_path('resources/dictionaries/american_players.yaml'));
$this->assertFileDoesNotExist(base_path('resources/dictionaries/canadian_players.yaml'));
$this->assertFileDoesNotExist(base_path('resources/js/react.js'));
$this->assertFileDoesNotExist(base_path('resources/js/vue.js'));

$this->installCoolRunnings();

@@ -1201,6 +1255,8 @@ public function it_installs_nested_modules_with_prompt_false_config_by_default_w
$this->assertFileExists(base_path('resources/dictionaries/players.yaml'));
$this->assertFileDoesNotExist(base_path('resources/dictionaries/american_players.yaml'));
$this->assertFileExists(base_path('resources/dictionaries/canadian_players.yaml'));
$this->assertFileDoesNotExist(base_path('resources/js/react.js'));
$this->assertFileExists(base_path('resources/js/vue.js'));
}

#[Test]
Loading
Oops, something went wrong.