Skip to content

Commit

Permalink
Don't run prefer-lowest tests with PHP 8.4
Browse files Browse the repository at this point in the history
The "lowest" versions of dependencies throw deprecation errors with PHP 8.4 - we only want to test with the latest versions for now.

This means we also don't need to adjust the minimum versions of dependencies.

This is what Laravel does in their test suite.
  • Loading branch information
duncanmcclean committed Nov 21, 2024
1 parent 36c8547 commit c37d23b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ jobs:
laravel: 11.*
- php: 8.4
laravel: 10.*
- php: 8.4
stability: prefer-lowest

name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.stability }} - ${{ matrix.os }}

Expand Down
5 changes: 2 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"composer/semver": "^3.4",
"guzzlehttp/guzzle": "^6.3 || ^7.0",
"james-heinrich/getid3": "^1.9.21",
"laravel/framework": "^10.40 || ^11.3",
"laravel/framework": "^10.40 || ^11.0",
"laravel/prompts": "^0.1.16",
"league/commonmark": "^2.2",
"league/csv": "^9.0",
Expand Down Expand Up @@ -44,8 +44,7 @@
"mockery/mockery": "^1.6.10",
"orchestra/testbench": "^8.14 || ^9.0",
"phpunit/phpunit": "^10.5.35",
"spatie/laravel-ray": "^1.37",
"spatie/ray": "^1.41.2"
"spatie/laravel-ray": "^1.37"
},
"config": {
"optimize-autoloader": true,
Expand Down

0 comments on commit c37d23b

Please sign in to comment.