removed unnecessary dependency #5641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javstash
added a commit
to javstash/stash
that referenced
this pull request
Feb 7, 2025
removed un-necesarry dependancy (stashapp#5641)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project currently includes 3 different UUID modules:
github.com/gofrs/uuid/v5
which is used directly by the github.com/stashapp/stash/pkg/scraper/stashbox package to check if a sting is a uuid.
github.com/google/uuid
indirectly by github.com/99designs/gqlgen/graphql which is heavily used in github.com/stashapp/stash/internal/api package.
github.com/nu7hatch/gouuid
indirectly used by github.com/go-toast/toast used in the github.com/stashapp/stash/internal/desktop.
So what this PR does is use one of the other already used UUID modules instead of pulling in yet another one to do the same task they can.