Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /stream endpoint serving directory for fileless scenes #3541

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

WithoutPants
Copy link
Collaborator

Fixes #3526

/stream endpoint now returns 404 if the scene has no files. The File Info tab is also now hidden when the scene has no files.

@WithoutPants WithoutPants added the bug Something isn't working label Mar 14, 2023
@WithoutPants WithoutPants added this to the Version 0.20.0 milestone Mar 14, 2023
@DingDongSoLong4
Copy link
Collaborator

As it is now, some of the info on the File Info tab isn't explicitly related to the files, like the scene URL (Downloaded From), Stash IDs and the activity tracking info. They will now be hidden when the scene has no files. Activity tracking doesn't really make sense without a file so that's fine, but the scene URL and Stash ID might be set on a fileless scene.

I don't think any of these should really be in a "File Info" tab anyway, so maybe the tab should be renamed to just "Info" or "Scene Info"? It would then make sense to move the Created At and Updated At lines to it as discussed in #2188.

@WithoutPants
Copy link
Collaborator Author

I think that non-file information should be moved out of the current File Info tab, and into the details tab, and that we could potentially split the details tab. For now, I'll revert the file info tab change and hide the stream link instead.

@WithoutPants WithoutPants merged commit 9bae98c into stashapp:develop Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Stream link for fileless scene serves home directory overview
2 participants