Added favorite button in Performer grid view

[CrookedDuck]

Resolves part of #705
By clicking the favorite icon the user can toggle whether or not the performer is favorite.

[kermieisinthehouse]

Thank your for your contribution! I'd love to merge this but there are a few outstanding comments:

• The state after clicking the icon is ambiguous, it is solid white both after favoriting and unfavoriting. (Tested on Firefox Mobile)
• For the unfavorited state, I believe the shadow should be less dark, and perhaps raise to the current level of darkness on hover.
• There are some lint errors that need to be fixed before CI passes.

Thanks! Feel free to comment with any questions.

[DogmaDragon]

Would love a show/hide toggle to be added in the settings. I see it adds a unique class so it can be hidden via CSS, but a toggle would be more user-friendly.

[cj12312021]

The usability of this button on mobile should be improved by removing the hover effects on the bottom. Currently, 2 clicks are required to favorite a performer. 1 click to register the hover effect, and another to actually click the button.

[cj12312021]

A 50% opacity shadow should be enough here.

[cj12312021]

Thanks for your contribution! In the future, it would make tester's lives easier if you don't push changes directly to the develop branch.

[kermieisinthehouse]

Thanks for your contribution! In the future, it would make tester's lives easier if you don't push changes directly to the develop branch.

I'm not sure I understand what this means?

[cj12312021]

I essentially had to delete the develop branch I had locally to check out his changes since it was pushed directly to the develop branch on his fork. It's not a huge deal but it was an inconvenience.

[kermieisinthehouse]

Ah, I see. I put the following in my .gitconfig,

[alias]
        pr = "!f() { if [ $# -lt 1 ]; then echo \"Usage: git pr <id> [<remote>]  # assuming <remote>[=origin] is on GitHub\"; else git checkout -q \"$(git rev-parse --verify HEAD)\" && git fetch -fv \"${2:-origin}\" pull/\"$1\"/head:pr/\"$1\" && git checkout pr/\"$1\"; fi; }; f"

So that I can do git pr 3369 and check out a new branch - then build the docker images from there.

[cj12312021]

Sounds like that would save me some trouble. I'll need to try it out. Thanks!

[CrookedDuck]

Thanks for your contribution! In the future, it would make tester's lives easier if you don't push changes directly to the develop branch.

ill keep in mind to create feature/issue related branches in the future, sorry for the inconvenience ;)

[WithoutPants]

Fixed up the compile errors and changed the styling to be consistent with the older version. Unfavorited performers now only show the favorite button when the performer card is hovered over, since having all the buttons shown was pretty ugly.