-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tenth place precision star rating #3343
Add tenth place precision star rating #3343
Conversation
How would one go about rating a tenth of a star? I doubt a star rating that precise is feasible to read (or click) on the edit page, especially on mobile. The card view is the least of the worries since that's in a decimal format regardless. |
The intention behind this change is mainly to allow the ability to view the number rating with a tenth-place precision rather than view the stars themselves. The star precision affects the decimal rating in the cards. So the quarter star precision ratings are displayed as 5, 5.75, 5.50, ..etc. That degree of rounding isn’t ideal when switching from decimal to stars. I imagine most people using this precious wouldn’t be doing their rating from the UI. |
For more context, my performer ratings come from votes submitted by thousands of people on a different online database. In this case, precision is important. Up until now, I've been using the decimal option because that displays the most precise number of the card. But that comes with the caveat that I lose stars when on the performer page. In order to keep the stars, the best option available is the quarter precision, which rounds the number up too much. Rather than reworking the rating implementation, this was the next best option. |
Looks ok. I think the |
This pull request adds an option for tenth-place precision star ratings, as I feel the quarter and half-star options aren't precise enough to consider them over the decimal option. It's always jarring to see so many performers with a 5-star rating with quarter precision.