Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tenth place precision star rating #3343

Merged

Conversation

cj12312021
Copy link
Collaborator

@cj12312021 cj12312021 commented Jan 5, 2023

This pull request adds an option for tenth-place precision star ratings, as I feel the quarter and half-star options aren't precise enough to consider them over the decimal option. It's always jarring to see so many performers with a 5-star rating with quarter precision.

Screenshot 2023-01-05 000121

@cj12312021 cj12312021 added improvement Something needed tweaking. ui Issues related to UI labels Jan 5, 2023
@sleetx
Copy link

sleetx commented Jan 5, 2023

How would one go about rating a tenth of a star? I doubt a star rating that precise is feasible to read (or click) on the edit page, especially on mobile. The card view is the least of the worries since that's in a decimal format regardless.

@cj12312021
Copy link
Collaborator Author

cj12312021 commented Jan 5, 2023

The intention behind this change is mainly to allow the ability to view the number rating with a tenth-place precision rather than view the stars themselves. The star precision affects the decimal rating in the cards. So the quarter star precision ratings are displayed as 5, 5.75, 5.50, ..etc. That degree of rounding isn’t ideal when switching from decimal to stars. I imagine most people using this precious wouldn’t be doing their rating from the UI.

@cj12312021
Copy link
Collaborator Author

For more context, my performer ratings come from votes submitted by thousands of people on a different online database. In this case, precision is important. Up until now, I've been using the decimal option because that displays the most precise number of the card. But that comes with the caveat that I lose stars when on the performer page. In order to keep the stars, the best option available is the quarter precision, which rounds the number up too much. Rather than reworking the rating implementation, this was the next best option.

@cj12312021
Copy link
Collaborator Author

My latest push includes the star rating value by the stars to make the exact value more readable, as seen in this image:
Screenshot 2023-01-06 225424

@WithoutPants
Copy link
Collaborator

Looks ok. I think the 0 value should be hidden when rating is unset.

@WithoutPants WithoutPants added this to the Version 0.20.0 milestone Feb 13, 2023
@WithoutPants WithoutPants merged commit ebf3a4b into stashapp:develop Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking. ui Issues related to UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants