Overhaul HLS streaming #3274
Merged
Overhaul HLS streaming #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2022
2895b13 to
0c4eced
Compare
d6c2361 to
0c4eced
Compare
0c4eced to
c9ed5b8
Compare
9b36ddc to
21c9aee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split off of #3058, without DASH and keeping the legacy live transcoding in. I've refactored it a lot to be more modular so adding DASH to this is very straightforward (#3275).
What I've changed with regards to the actual streaming logic is that now ffmpeg writes only to temp files and stash is responsible for renaming them to the actual segment files before they are streamed. This means that the incomplete last segment that ffmpeg leaves behind after exiting can be easily discarded.
From my simple testing this seems to have finally fixed all of the the skipping/stuttering issues, for both HLS and DASH, but more thorough testing is welcome.
Fixes #2901
Should close #2831
Should fix #2688
Should fix #2609
Could fix #2934