Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search icon, scene form tag remove button #390

Merged
3 commits merged into from
May 20, 2022
Merged

Fix search icon, scene form tag remove button #390

3 commits merged into from
May 20, 2022

Conversation

peolic
Copy link
Contributor

@peolic peolic commented May 20, 2022 •
edited
Loading

Fixes:
image
Tag X button styling:
image

There are a lot of renames in v6:
https://fontawesome.com/docs/web/setup/upgrade/whats-changed#icons-renamed-in-version-6

Checked Stash-Box code, only these icons had a custom styling which was affected by the rename.
The other icons are:

faEdit ➡️ faPenToSquare
faQuestionCircle ➡️ faCircleQuestion
faSortAmountUp ➡️ faArrowUpWideShort
faSortAmountDown ➡️ faArrowDownWideShort
faExclamationTriangle ➡️ faTriangleExclamation
faCheckCircle ➡️ faCircleCheck
faBirthdayCake ➡️ faCakeCandles
faSyncAlt ➡️ faRotate
faUserEdit ➡️ faUserPen

@peolic peolic mentioned this pull request May 20, 2022
Closed
@ghost ghost merged commit 7acb722 into stashapp:master May 20, 2022
@peolic peolic deleted the renamed-icons branch May 20, 2022 21:07
InfiniteStash pushed a commit that referenced this pull request Nov 9, 2022
@peolic
Fix search icon, scene form tag remove button (#390)
e3678a0
InfiniteStash pushed a commit that referenced this pull request Nov 9, 2022
@peolic
Fix search icon, scene form tag remove button (#390)
3aaba4d
Maista6969 pushed a commit to Maista6969/stash-box that referenced this pull request Jun 24, 2023
@peolic @Maista6969
Fix search icon, scene form tag remove button (stashapp#390)
6ae442d
feederbox826 pushed a commit to feederbox826/stash-box that referenced this pull request Nov 15, 2023
@peolic @feederbox826
Fix search icon, scene form tag remove button (stashapp#390)
2e632ca
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peolic