URLInput fixes #319
Merged
URLInput fixes #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a duplicate url was added, removing it would cause the first url to be removed and then the remove buttons would not remove the correct urls. same issue as BodyMods had previously, fixed by using `remove` directly.
also reset site select on paste if url does not match any site prevents mistakenly adding urls for unmatching sites
e1edaca to
793a3f8
Compare
InfiniteStash
pushed a commit
that referenced
this pull request
Nov 9, 2022
* fix removing sites if a duplicate url was added, removing it would cause the first url to be removed and then the remove buttons would not remove the correct urls. same issue as BodyMods had previously, fixed by using `remove` directly. * force site detection on paste event also reset site select on paste if url does not match any site prevents mistakenly adding urls for unmatching sites
InfiniteStash
pushed a commit
that referenced
this pull request
Nov 9, 2022
* fix removing sites if a duplicate url was added, removing it would cause the first url to be removed and then the remove buttons would not remove the correct urls. same issue as BodyMods had previously, fixed by using `remove` directly. * force site detection on paste event also reset site select on paste if url does not match any site prevents mistakenly adding urls for unmatching sites
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.