[Feature] Show pending scene submissions on performer page

[JanJastrow]

Is your feature request related to a problem? Please describe.
Since there is no search function on the edits page currently, it's hard to figure out if a new scene has already been posted.
(Happens with fresh releases)

Describe the solution you'd like
Show on the performers page a link to current pending scenes (just like performer edits right now)

[peolic]

the title of #301 doesn't make it obvious, but it's basically the same feature for both performers and studios.

[Flashy78]

This has been implemented and can be closed.

[JanJastrow]

Can you point me to the commit where this was implemented?
In the current live version at StashDB it is not implemented yet.

[Flashy78]

Ah ok, I understand after you changed the title.
The pending edits of a performer are shown, you want to see scenes for that performer.

[JanJastrow]

Yes, I think the word "edits" was misleading.
I want an easy way to add check if a performer has currently pending scenes.
Currently I add them to Favs => Go to Pendings Edits => Filter "Favs" and then look around.

Should be rather easy to implement with a query.

[ikmckenz]

@InfiniteStash Would you prefer this to work by modifying the existing queryEdits to add support for cross-target edits (like, query scene edits by performer id, or scene edits by studio id), or would you prefer to see a new backend query for these types of cross target queries?

[InfiniteStash]

@InfiniteStash Would you prefer this to work by modifying the existing queryEdits to add support for cross-target edits (like, query scene edits by performer id, or scene edits by studio id), or would you prefer to see a new backend query for these types of cross target queries?

I think it makes the most sense to add a subquery to the existing condition here:

stash-box/pkg/sqlx/querybuilder_edit.go

Line 223 in 6dbce61

query.AddWhere(fmt.Sprintf(`

That one is already wired up on the frontend. It should just be a matter of selecting edits which have data->new->performers that include the target_id. I forget how you check if a json array contains an id, but it's used in various places already.

[ikmckenz]

Okay I think I understand now, so your preferred solution modifies the existing queryEdits with a target id to not just return edits to the performer, for example, but to return both edits to the performer, and pending scene edits containing the performer, and have both displayed along side each other in the Edits tab. This would also mean we get the same for studios without further changes (get not just studio edits, but also scene edits containing the studio in the tab).
That might be slightly complicated because performers and studios have slightly different shape in the edit data JSON, but I'll play with the idea a bit and see what I can do.

[ikmckenz]

Have the above working in PR #925, I don't love how the code looks generally but don't really see a super clean way to organize the code at this time.

Spent all too much time looking at query plans for these queries, managed to get them all looking good, no nested loops. Querying the performers with jsonb_array_elements() necessitated a nested loop but moving tojsonb_path_query_array() gets rid of it, I do see jsonb_array_elements() used in a few places throughout the code so might go on a query optimization drive after this.