Add security_bites function to PcsConfig

[alon-f]

No description provided.

[reviewable-StarkWare]

This change is 

[alon-f]

• Add security_bites function to PcsConfig #998 👈 (View in Graphite)
• Add PcsConfig to CommitmentSchemeProof #996
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.92%. Comparing base (0445252) to head (70437c2).

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #998   +/-   ##
=======================================
  Coverage   92.91%   92.92%           
=======================================
  Files         105      105           
  Lines       14208    14221   +13     
  Branches    14208    14221   +13     
=======================================
+ Hits        13202    13215   +13     
  Misses        927      927           
  Partials       79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alon-f)

---

crates/prover/src/core/pcs/mod.rs line 36 at r1 (raw file):

    pub fri_config: FriConfig,
}

remove empty line

---

crates/prover/src/core/pcs/mod.rs line 58 at r1 (raw file):

        let config = super::PcsConfig {
            pow_bits: 26,
            fri_config: super::FriConfig::new(1, 1, 70),

consider to change to a larger blowup factor

Code quote:

super::FriConfig::new(1, 1, 70)

[alon-f]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @shaharsamocha7)

---

crates/prover/src/core/pcs/mod.rs line 36 at r1 (raw file):

Previously, shaharsamocha7 wrote…

remove empty line

So you like to have the struct and the impl close together?

[shaharsamocha7]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @alon-f)

---

crates/prover/src/core/pcs/mod.rs line 36 at r1 (raw file):

Previously, alon-f wrote…

So you like to have the struct and the impl close together?

For the impl of the struct itself, yes.
Do we have another convention as a company or something?