fix: correct enum typed data hashing #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penovicp
added a commit
to penovicp/starknet.js
that referenced
this pull request
Jan 7, 2025
penovicp
added a commit
to penovicp/starknet.js
that referenced
this pull request
Jan 7, 2025
* revert "fix: rectify snip-12 violation by removing extra `:` in enum encoding (starknet-io#1288)" ** this reverts commit b903116. * revert "fix: correct enum typed data hashing (starknet-io#1281)" ** this reverts commit 6e353d3.
penovicp
added a commit
to penovicp/starknet.js
that referenced
this pull request
Jan 7, 2025
* revert "fix: rectify snip-12 violation by removing extra `:` in enum encoding (starknet-io#1288)" - this reverts commit b903116 * revert "fix: correct enum typed data hashing (starknet-io#1281)" - this reverts commit 6e353d3
penovicp
added a commit
that referenced
this pull request
Jan 7, 2025
penovicp
added a commit
that referenced
this pull request
Jan 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 8, 2025
# [6.21.0](v6.20.3...v6.21.0) (2025-01-08) ### Bug Fixes * correct enum typed data hashing ([#1281](#1281)) ([6e353d3](6e353d3)) * rectify snip-12 violation by removing extra `:` in enum encoding ([#1288](#1288)) ([b903116](b903116)) * repair fetch utility for browser environments ([#1293](#1293)) ([2cb1332](2cb1332)) ### Features * enable base fetch override ([#1279](#1279)) ([0fce61e](0fce61e))
|
🎉 This PR is included in version 6.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Fixes #1278
Checklist: