Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: getStarkName & getStarkProfile to work with latest version of contract #1093

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
262 changes: 161 additions & 101 deletions src/provider/extensions/starknetId.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { BigNumberish, StarkProfile } from '../../types';
import { BigNumberish, RawArgsArray, StarkProfile } from '../../types';
import { CallData } from '../../utils/calldata';
import { getSelectorFromName } from '../../utils/hash';
import { decodeShortString, encodeShortString } from '../../utils/shortString';
Expand Down Expand Up @@ -67,13 +67,7 @@ export class StarknetId {
const contract = StarknetIdContract ?? getStarknetIdContract(chainId);

try {
const hexDomain = await provider.callContract({
contractAddress: contract,
entrypoint: 'address_to_domain',
calldata: CallData.compile({
address,
}),
});
const hexDomain = await this.executeStarkName(provider, address as string, contract);
const decimalDomain = hexDomain.map((element) => BigInt(element)).slice(1);

const stringDomain = useDecoded(decimalDomain);
Expand All @@ -91,6 +85,29 @@ export class StarknetId {
}
}

static async executeStarkName(provider: ProviderInterface, address: string, contract: string) {
try {
// Attempt the initial call with the hint parameter
return await provider.callContract({
contractAddress: contract as string,
entrypoint: 'address_to_domain',
calldata: CallData.compile({
address,
hint: [],
}),
});
} catch (initialError) {
// If the initial call fails, try with the fallback calldata without the hint parameter
return await provider.callContract({
contractAddress: contract as string,
entrypoint: 'address_to_domain',
calldata: CallData.compile({
address,
}),
});
}
}

static async getAddressFromStarkName(
provider: ProviderInterface,
name: string,
Expand Down Expand Up @@ -136,101 +153,116 @@ export class StarknetId {
const multicallAddress = StarknetIdMulticallContract ?? getStarknetIdMulticallContract(chainId);

try {
const data = await provider.callContract({
contractAddress: multicallAddress,
entrypoint: 'aggregate',
calldata: CallData.compile({
calls: [
{
execution: execution({}),
to: dynamicFelt(contract),
selector: dynamicFelt(getSelectorFromName('address_to_domain')),
calldata: [dynamicCallData(address)],
},
{
execution: execution({}),
to: dynamicFelt(contract),
selector: dynamicFelt(getSelectorFromName('domain_to_id')),
calldata: [dynamicCallData(undefined, undefined, [0, 0])],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('twitter')),
dynamicCallData(verifierContract),
dynamicCallData('0'),
],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('github')),
dynamicCallData(verifierContract),
dynamicCallData('0'),
],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('discord')),
dynamicCallData(verifierContract),
dynamicCallData('0'),
],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('proof_of_personhood')),
dynamicCallData(popContract),
dynamicCallData('0'),
],
},
// PFP
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('nft_pp_contract')),
dynamicCallData(pfpContract),
dynamicCallData('0'),
],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_extended_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('nft_pp_id')),
dynamicCallData('2'),
dynamicCallData(pfpContract),
dynamicCallData('0'),
],
},
{
execution: execution(undefined, undefined, [6, 0, 0]),
to: dynamicFelt(undefined, [6, 0]),
selector: dynamicFelt(getSelectorFromName('tokenURI')),
calldata: [dynamicCallData(undefined, [7, 1]), dynamicCallData(undefined, [7, 2])],
},
],
}),
const initialCalldata: RawArgsArray = [];
const fallbackCalldata: RawArgsArray = [];

initialCalldata.push({
execution: execution({}),
to: dynamicCallData(contract),
selector: dynamicCallData(getSelectorFromName('address_to_domain')),
calldata: [dynamicCallData(address), dynamicCallData('0')],
});
fallbackCalldata.push({
execution: execution({}),
to: dynamicCallData(contract),
selector: dynamicFelt(getSelectorFromName('address_to_domain')),
calldata: [dynamicCallData(address)],
});

const calls = [
{
execution: execution({}),
to: dynamicFelt(contract),
selector: dynamicFelt(getSelectorFromName('domain_to_id')),
calldata: [dynamicCallData(undefined, undefined, [0, 0])],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('twitter')),
dynamicCallData(verifierContract),
dynamicCallData('0'),
],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('github')),
dynamicCallData(verifierContract),
dynamicCallData('0'),
],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('discord')),
dynamicCallData(verifierContract),
dynamicCallData('0'),
],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('proof_of_personhood')),
dynamicCallData(popContract),
dynamicCallData('0'),
],
},
// PFP
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('nft_pp_contract')),
dynamicCallData(pfpContract),
dynamicCallData('0'),
],
},
{
execution: execution({}),
to: dynamicFelt(identityContract),
selector: dynamicFelt(getSelectorFromName('get_extended_verifier_data')),
calldata: [
dynamicCallData(undefined, [1, 0]),
dynamicCallData(encodeShortString('nft_pp_id')),
dynamicCallData('2'),
dynamicCallData(pfpContract),
dynamicCallData('0'),
],
},
{
execution: execution(undefined, undefined, [6, 0, 0]),
to: dynamicFelt(undefined, [6, 0]),
selector: dynamicFelt(getSelectorFromName('tokenURI')),
calldata: [dynamicCallData(undefined, [7, 1]), dynamicCallData(undefined, [7, 2])],
},
];

initialCalldata.push(...calls);
fallbackCalldata.push(...calls);

const data = await this.executeStarkProfile(
provider,
multicallAddress,
'aggregate',
initialCalldata,
fallbackCalldata
);

if (Array.isArray(data)) {
// Format data
const size = parseInt(data[0], 16);
Expand Down Expand Up @@ -288,4 +320,32 @@ export class StarknetId {
throw Error('Could not get user stark profile data from address');
}
}

static async executeStarkProfile(
provider: ProviderInterface,
contract: string,
functionName: string,
initialCalldata: RawArgsArray,
fallbackCalldata: RawArgsArray
) {
try {
// Attempt the initial call with the hint parameter
return await provider.callContract({
contractAddress: contract as string,
entrypoint: functionName,
calldata: CallData.compile({
calls: initialCalldata,
}),
});
} catch (initialError) {
// If the initial call fails, try with the fallback calldata without the hint parameter
return await provider.callContract({
contractAddress: contract as string,
entrypoint: functionName,
calldata: CallData.compile({
calls: fallbackCalldata,
}),
});
}
}
}