-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: front page #17
docs: front page #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried using GitHub review - let me know how it works.
src/config/home.json
Outdated
"img": "undraw_docusaurus_tree.svg", | ||
"title": "building on starknet", | ||
"text": "useful link to help write and deploy your own contracts on starknet" | ||
"text": "Introduction to StarkNet: how it works, main concepts glossary, FAQs" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have an intro to StarkNet yet. I would change this sentence to describe the technical docs. We don't have a glossary nor FAQs here.
src/config/home.json
Outdated
@@ -1,38 +1,32 @@ | |||
[ | |||
{ | |||
"linkName": "docs/CLI/commands", | |||
"linkName": "docs/Intro", | |||
"img": "undraw_docusaurus_mountain.svg", | |||
"title": "what is starkNet", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"title": "what is starkNet", | |
"title": "What is StarkNet", |
src/config/home.json
Outdated
"title": "dev tools", | ||
"text": "tools for development and deployment" | ||
"title": "Hello StarkNet!", | ||
"text": "Your StarkNet first steps" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "Your first steps in StarkNet"
src/config/home.json
Outdated
"img": "undraw_docusaurus_react.svg", | ||
"title": "latest updates", | ||
"text": "stay up to date with all the latest blog posts, news, and events" | ||
"text": "StarkNet newsletter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"text": "StarkNet newsletter" | |
"text": "StarkNet's unofficial newsletter" |
223ea22
to
dc987c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 4 unresolved discussions (waiting on @bbrandtom)
src/config/home.json, line 5 at r1 (raw file):
Previously, bbrandtom (Tom Brand) wrote…
"title": "What is StarkNet",
Done.
src/config/home.json, line 6 at r1 (raw file):
Previously, bbrandtom (Tom Brand) wrote…
We don't have an intro to StarkNet yet. I would change this sentence to describe the technical docs. We don't have a glossary nor FAQs here.
Done.
src/config/home.json, line 12 at r1 (raw file):
Previously, bbrandtom (Tom Brand) wrote…
maybe "Your first steps in StarkNet"
Done.
src/config/home.json, line 30 at r1 (raw file):
Previously, bbrandtom (Tom Brand) wrote…
"text": "StarkNet's unofficial newsletter"
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bbrandtom)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bbrandtom)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dismissed @bbrandtom from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)
Description of the Changes
Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.
Check List
<docs/feat/fix/chore>(optional scope): <description>
, e.g:fix: minor typos in code
This change is