Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: front page #17

Merged
merged 5 commits into from
Mar 12, 2022
Merged

docs: front page #17

merged 5 commits into from
Mar 12, 2022

Conversation

ArielElp
Copy link
Collaborator

@ArielElp ArielElp commented Mar 1, 2022

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

Check List

  • Changes have been done against dev branch, and PR does not conflict
  • Docs have been updated
  • PR title is follow the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

@ArielElp ArielElp requested a review from bbrandtom March 1, 2022 09:36
Copy link
Member

@bbrandtom bbrandtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried using GitHub review - let me know how it works.

"img": "undraw_docusaurus_tree.svg",
"title": "building on starknet",
"text": "useful link to help write and deploy your own contracts on starknet"
"text": "Introduction to StarkNet: how it works, main concepts glossary, FAQs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have an intro to StarkNet yet. I would change this sentence to describe the technical docs. We don't have a glossary nor FAQs here.

@@ -1,38 +1,32 @@
[
{
"linkName": "docs/CLI/commands",
"linkName": "docs/Intro",
"img": "undraw_docusaurus_mountain.svg",
"title": "what is starkNet",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "what is starkNet",
"title": "What is StarkNet",

"title": "dev tools",
"text": "tools for development and deployment"
"title": "Hello StarkNet!",
"text": "Your StarkNet first steps"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe "Your first steps in StarkNet"

"img": "undraw_docusaurus_react.svg",
"title": "latest updates",
"text": "stay up to date with all the latest blog posts, news, and events"
"text": "StarkNet newsletter"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"text": "StarkNet newsletter"
"text": "StarkNet's unofficial newsletter"

Copy link
Collaborator Author

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 4 unresolved discussions (waiting on @bbrandtom)


src/config/home.json, line 5 at r1 (raw file):

Previously, bbrandtom (Tom Brand) wrote…
    "title": "What is StarkNet",

Done.


src/config/home.json, line 6 at r1 (raw file):

Previously, bbrandtom (Tom Brand) wrote…

We don't have an intro to StarkNet yet. I would change this sentence to describe the technical docs. We don't have a glossary nor FAQs here.

Done.


src/config/home.json, line 12 at r1 (raw file):

Previously, bbrandtom (Tom Brand) wrote…

maybe "Your first steps in StarkNet"

Done.


src/config/home.json, line 30 at r1 (raw file):

Previously, bbrandtom (Tom Brand) wrote…
    "text": "StarkNet's unofficial newsletter"

Done.

Copy link
Member

@bbrandtom bbrandtom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bbrandtom)

Copy link
Collaborator Author

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bbrandtom)

@ArielElp ArielElp requested review from bbrandtom and removed request for bbrandtom March 12, 2022 07:46
Copy link
Collaborator Author

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dismissed @bbrandtom from a discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)

@ArielElp ArielElp merged commit c8fd5a6 into dev Mar 12, 2022
@ArielElp ArielElp deleted the ariel/front_page branch March 12, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants